feat: build .NET Standard 2.0 version#131
Merged
adamsitnik merged 2 commits intoa2aproject:mainfrom Aug 1, 2025
Merged
Conversation
Contributor
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
brandonh-msft
added a commit
that referenced
this pull request
Aug 25, 2025
brandonh-msft
added a commit
that referenced
this pull request
Aug 25, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 26, 2025
) * fix: Use custom `JsonConverter` for `A2AEvent` and `A2AResponse` instead of `[JsonPolymorphic]` to fix discriminator deserialization issues * Alternate implementation for kind serialization Fixes #131 * Update tests/A2A.UnitTests/Models/A2AResponseTests.cs per copilot naming suggestion Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * doesn't make sense to allow construction of these types externally because they would require an additional discriminator specification * allowing for type discriminator anywhere in JSON payload by utilizing package-provided STJ v9 and setting the property accordingly * Adding some MessageSendParams tests * Fix for polymorphic serialization to occur An internal property that is serialized/deserialized, but as the base type to trigger the correct polymorphic serialization behavior, specifically the addition of the discriminator value. We Obsolete and hide this, however, so that it's not inadvertently used by developers since it's intended ONLY for serialization purposes * Update src/A2A/Models/MessageSendParams.cs spellcheck Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Don't actually need the `Kind` property since it's implicit in the object type * reducing PR impact consts were nice, but not required to fix the issue * Added UT for #160 Related Work Items: #160 * Adding UT to ensure bad message params fail deserialization * JsonValue -> MessageJsonValue * reorganizing UTs * more targeted inclusion of STJ 9 --------- Co-authored-by: Radek Bartoň <radek.barton@microsoft.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit shows the issue: